Consolidate the way we write CSS

victorporof commented 8 years ago

There have been ongoing discussions the last week about how we're going to go about writing CSS. Currently things are ok, but they are inconsistent and suffer from the age-old problem of CSS: cascading, improper modularity, lack of namespacing etc.

Inline styles make things way better, but they suffer from a few problems. The more objective ones are:

pseudo-selectors are clunky, :hover, :visited, etc. are hard to use, unless using event handlers
shadow dom is almost impossible to style (e.g. browser-defined insides of some nodes)
hey make the DOM bigger and hard to inspect
theming information would require being part of application state.

The general conclusion was that a mix of css files and inlined styles would be nice. React-free-style could help us with that: https://github.com/blakeembrey/react-free-style. Alternatively we could also write our own thing.

This issue is about unifying the way we do things.

victorporof commented 8 years ago

Also relevant to leave here: https://github.com/blakeembrey/free-style#why

victorporof commented 8 years ago

Fixed by https://github.com/mozilla/tofino/pull/163

mozilla / tofino

Consolidate the way we write CSS #113