search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Session restore stores ghost tabs #1505

Closed jsantell closed 7 years ago

jsantell commented 7 years ago

Somehow during session restore, I have 1 tab open before closing, and when restarting, I see a bunch of other tabs that no longer exist, and I only have one open. And there's lots of redux spam setting all this up. Not sure how I got to this state yet, but definitely slows this down.

screen shot 2016-11-01 at 12 56 04 pm
jsantell commented 7 years ago

This also creates content divs/webviews for each of these, which is probably the real source of slow down, but no tabs to access/actually see them

jsantell commented 7 years ago

I would note that this is beyond a UX bug, this grinds performance to the ground as handfuls of ghost webviews are created when restarting in dev environment and just one visible tab is open (luckily have not run into this in production).

jsantell commented 7 years ago

(nuking the session.json fixes this however)

joewalker commented 7 years ago

I would note that this is beyond a UX bug

That's true. The new label that I'm proposing in place of the milestone takes out the 'UI' part.

jsantell commented 7 years ago

Closing, will reopen if see it again.