search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Don't mutate displayOrder if we can't find the page we're moving. #1534

Closed rnewman closed 7 years ago

mozilla-licensing commented 7 years ago

Hi there! Thanks for your pull request. This is a reminder that unless you have a separate agreement with Mozilla, your code Submissions to this Mozilla open source project are made under the terms of the corresponding license of the particular open source project to which you are contributing. For more information on the specific license, please see the LICENSE file in the corresponding repository.

If you did not write the code that you are Submitting, please help us by providing information described in our Commit Access Requirements so that a reviewer can conduct diligence.

If you don't want to see this reminder again, you can respond 'I understand'.

rnewman commented 7 years ago

Extended still further, @jsantell. r?

rnewman commented 7 years ago

Landed with @jsantell's suggestion to throw in both cases.

48284dc