Only select the URL bar on navigation if the page is the homepage, and

mozilla / tofino

Project Tofino is a browser interaction experiment.

https://mozilla.github.io/tofino

Apache License 2.0

647 stars 68 forks source link

Only select the URL bar on navigation if the page is the homepage, and #1540

Closed jsantell closed 7 years ago

jsantell commented 7 years ago

do not select the URL bar on history forking. Fixes #1521. r=vporof

I think focusing on did-navigate and did-stop-navigation is for selecting it upon a new tab. As a follow up, we should probably mark page models whether or not they have navigated at all to determine focus (if I manually type in tofino://history, I would expect it to not get focused), but that's a bit more of an edge case.

jsantell commented 7 years ago

Adding stubs since forking page sagas aren't tested at all

jsantell commented 7 years ago

The fork tests will be easier once #1543 lands too with the url utility

jsantell commented 7 years ago

@victorporof added saga test