search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Enable drag/drop for tabs. Fixes #1167 #1562

Closed bgrins closed 7 years ago

bgrins commented 7 years ago

This adds tab reordering using https://github.com/gaearon/react-dnd - pretty easy. I'm not sure the best way to test this without using end to end tests though, open to suggestions.

victorporof commented 7 years ago

I've never used react-dnd myself. Does this update the app state accordingly as well?

bgrins commented 7 years ago

One more case we should handle is not allowing a non-pinned tab to drag in front of a pinned tab. Might be follow up material, but should be relatively easy (only allow changing positions on pinned tabs with other pinned, and vice versa)