search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Don't prompt for setting the default browser in test. #1569

Closed rnewman closed 7 years ago

rnewman commented 7 years ago

The default browser prompt is why this test was perma-failing on macOS.

The test heuristics right at the end also are apparently wrong (at least on macOS), so I commented those out.

This introduces a build config flag offerDefault, and uses that instead of switching on development.

rnewman commented 7 years ago

@mossop doesn't have a Mac; mostly I want CI for this, but @jsantell, could you take a look?

rnewman commented 7 years ago

Landed on master, plus backed out the UAS change :/

3da1bda