search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Logging in on twitter.com doesn't work #193

Closed victorporof closed 8 years ago

victorporof commented 8 years ago

Looks like we're not handling redirects properly? There's a spew of command {"payload":{"url":"https://twitter.com/"},"type":"PROFILE_COMMAND_VISITED"} when trying to log in. @ncalexan maybe you know what's up?

ncalexan commented 8 years ago

I do not think we're handling redirects properly; but this spew is because we can't yet differentiate between iframe loads and main frame loads. These are just telling the profile, "I visited here", and then after the redirect, "I visited here".

On Tue, Apr 19, 2016 at 10:52 PM, Victor Porof notifications@github.com wrote:

Looks like we're not handling redirects properly? There's a spew of command {"payload":{"url":"https://twitter.com/ "},"type":"PROFILE_COMMAND_VISITED"} when trying to log in. @ncalexan https://github.com/ncalexan maybe you know what's up?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mozilla/tofino/issues/193

Mossop commented 8 years ago

This is just a bug in electron: https://github.com/electron/electron/issues/3471

Mossop commented 8 years ago

Looks like Electron are waiting for a new Chrome refactor to happen which is tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=368813.

Given the number of blocking bugs I wouldn't expect us to see this fixed until after our three months are up so I think we should fork electron to just take the fix ourselves.