mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

`npm run coverage` broken #314

Closed jsantell closed 8 years ago

jsantell commented 8 years ago
$ npm run coverage

> tofino@0.1.0 coverage /Users/jsantell/Dev/tofino
> nyc report --reporter=text-lcov | coveralls

/Users/jsantell/Dev/tofino/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

npm ERR! Darwin 14.0.0
npm ERR! argv "/Users/jsantell/.nvm/versions/node/v5.8.0/bin/node" "/Users/jsantell/.nvm/versions/node/v5.8.0/bin/npm" "run" "coverage"
npm ERR! node v5.8.0
npm ERR! npm  v3.7.3
npm ERR! code ELIFECYCLE
npm ERR! tofino@0.1.0 coverage: `nyc report --reporter=text-lcov | coveralls`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the tofino@0.1.0 coverage script 'nyc report --reporter=text-lcov | coveralls'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the tofino package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     nyc report --reporter=text-lcov | coveralls
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs tofino
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls tofino
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jsantell/Dev/tofino/npm-debug.log
victorporof commented 8 years ago

@linclark any clues? Is that command supposed to be run standalone?

linclark commented 8 years ago

I'm fairly certain that it worked when I added it. But it does seem to be broken now and I'm not sure that it's worth the work to fix it. Do folks want to be able to run it locally? If we have coveralls giving us reporting I think that's enough.

That said, Coveralls didn't run on my last PR. Does anyone know whether it has stopped? And if so, when? I doubt that this issue is causing that one, though, since I see coveralls reports from 4 days ago.

linclark commented 8 years ago

It looks like coveralls ran 4 hours ago. It uses the npm run coverage run script. I'd say let's leave it as is—working on CI and broken on local—unless anyone really wants to look into it.

victorporof commented 8 years ago

sgtm