search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
649 stars 67 forks source link

`nvm` can't be used in fish shell #507

Closed victorporof closed 8 years ago

victorporof commented 8 years ago

See https://github.com/creationix/nvm/issues/303

Should our readme cater to people who don't use more well known shells like bash or zsh? If so, we should tell them to install fnm instead, via fisherman or oh-my-fish or whatever other shell utility package manager they use.

Mossop commented 8 years ago

Maybe now homebrew's default node install is actually a version of node we use we should just switch to brew install node.

victorporof commented 8 years ago

brew install node does install the latest node and nvm.

Currently it's node v6.2.0 and npm 3.8.9.

Problem is, what we require and what brew installs might change.

linclark commented 8 years ago

The brew install of node can cause problems for people. When I was at npm, the folks there were pretty adamant about not recommending it. Instead, the recommendation was to install/update from the nodejs.org itself. I don't know whether that's still the case.

victorporof commented 8 years ago

@linclark any specific kind of problems, or just the age-old "we don't maintain the formula so we have no control over what might happen"?

linclark commented 8 years ago

I think it was a little bit of the latter, but also IIRC it didn't set the right permissions on the global install directories. It's not too hard to change that, but it can be confusing for people who aren't familiar with npm because npm just spews EACCES at you.

linclark commented 8 years ago

Just did a little research and it looks like that isn't a problem with the homebrew version anymore, so brew should be fine.

victorporof commented 8 years ago

Alright, I'm updating the readme.

victorporof commented 8 years ago

https://github.com/mozilla/tofino/commit/62c589554bcfbfefc723d9b3e7c89f66f3bacb25

victorporof commented 8 years ago

Thanks @linclark for the input!