Closed victorporof closed 8 years ago
r? @victorporof or @Mossop
Looks good to me
This should be closed after fc948f9 merged.
This was failing travis: https://travis-ci.org/mozilla/tofino/builds/122307177
It looks like it failed because you force pushed destroying the commit that Travis was trying to test.
:(
Discussed in #general with @bgrins about changing his merge message to be more descriptive, hence the force push.
The force push passed tests so you can just ignore the failure on the PR and close this I think.
https://travis-ci.org/mozilla/tofino/builds/122313652
On Mon, Apr 11, 2016 at 11:58 AM, Victor Porof notifications@github.com wrote:
Discussed in #general with @bgrins https://github.com/bgrins about changing his merge message to be more descriptive, hence the force push.
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mozilla/tofino/issues/63#issuecomment-208499331
@Mossop problem is, it's showing up in other PRs like https://github.com/mozilla/tofino/pull/71
Strange. I've seen travis get confused with force pushes. Maybe the problem will resolve when something new gets committed?
@Mossop Hopefully.
Started happening after https://github.com/mozilla/tofino/pull/62
After this,
gulp run
is failing on a fresh clone, even after anpm install
: