mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
649 stars 67 forks source link

Can't find a local build of electron anymore #63

Closed victorporof closed 8 years ago

victorporof commented 8 years ago

Started happening after https://github.com/mozilla/tofino/pull/62

After this, gulp run is failing on a fresh clone, even after a npm install:

fs.js:584
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/Users/victorporof/Desktop/tofino/node_modules/electron-prebuilt/dist/Electron.app/Contents/MacOS/version'
    at Error (native)
    at Object.fs.openSync (fs.js:584:18)
    at Object.fs.readFileSync (fs.js:431:33)
    at Object.getElectronVersion (utils.js:25:13)
    at Object.<anonymous> (config-builder.js:25:24)
    at Module._compile (module.js:413:34)
    at loader (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
gabrielluong commented 8 years ago

r? @victorporof or @Mossop

bgrins commented 8 years ago

Looks good to me

gabrielluong commented 8 years ago

This should be closed after fc948f9 merged.

victorporof commented 8 years ago

This was failing travis: https://travis-ci.org/mozilla/tofino/builds/122307177

Mossop commented 8 years ago

It looks like it failed because you force pushed destroying the commit that Travis was trying to test.

victorporof commented 8 years ago

:(

victorporof commented 8 years ago

Discussed in #general with @bgrins about changing his merge message to be more descriptive, hence the force push.

Mossop commented 8 years ago

The force push passed tests so you can just ignore the failure on the PR and close this I think.

https://travis-ci.org/mozilla/tofino/builds/122313652

On Mon, Apr 11, 2016 at 11:58 AM, Victor Porof notifications@github.com wrote:

Discussed in #general with @bgrins https://github.com/bgrins about changing his merge message to be more descriptive, hence the force push.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mozilla/tofino/issues/63#issuecomment-208499331

victorporof commented 8 years ago

@Mossop problem is, it's showing up in other PRs like https://github.com/mozilla/tofino/pull/71

Mossop commented 8 years ago

Strange. I've seen travis get confused with force pushes. Maybe the problem will resolve when something new gets committed?

victorporof commented 8 years ago

@Mossop Hopefully.