search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Suggestions should be clickable and hoverable #642

Closed jsantell closed 8 years ago

jsantell commented 8 years ago
screen shot 2016-06-07 at 2 47 54 pm

As they are now, they react to neither and I'd expect them to be clickable, and also be highlighted in unison with the title

bgrins commented 8 years ago

It'd be nice to have some mockup for these autocomplete suggestions. Do we event want to show the page content directly inline in the autocomplete popup? If so, what should it look like? @phlsa, any guidance?

phlsa commented 8 years ago

Hm, how do I get to the state in Jordans screen shot? I have to admit that I haven't really been using Tofino up until we started with builds...

jsantell commented 8 years ago

Going to a page and then type the page again into the URL bar so the suggestions pop up -- CNN news pages seem to consistently have some sort of metadata to display

bgrins commented 8 years ago

You might need to do hamburger -> fetch page contents to get it to work (don't think we are automatically saving content)

bgrins commented 8 years ago

to be clear, the URL and page title are clickable / hoverable, it's the additional content (readability version of the page) that is tacked on. A text match could have happened in that content but not the url/title, which is why it's currently visible. We could always hide that content for now, but if you had ideas of what a richer autocomplete suggestion would look like that would be helpful (i.e. more than just page title / url / favicon)

phlsa commented 8 years ago

Per #740, let's hide the full text by default. A slightly longer explanation is in that issue :)

victorporof commented 8 years ago

Fixed by the frontend rewrite.