search

mozilla / tofino

Project Tofino is a browser interaction experiment.
https://mozilla.github.io/tofino
Apache License 2.0
647 stars 68 forks source link

Failed prop type: Required prop `src` was not specified in `Thumbnail` #861

Closed jsantell closed 8 years ago

jsantell commented 8 years ago

After merging in #856, this started occuring. Looks like both Thumbnail and BaseCard are both using the backgroundImage. I'm not sure what's intended here, which should be removed?

warning.js:44Warning: Failed prop type: Required prop src was not specified in Thumbnail

victorporof commented 8 years ago

None should be removed, just need to supply them in tests so react doesn't complain.

victorporof commented 8 years ago

Now I see this happens at runtime! Fixed by https://github.com/mozilla/tofino/commit/d84df787b1bbaac67c6667c62f2d33203f2b9679