search

mozilla / translate

Translations website utilizing Bergamot proceedings
https://mozilla.github.io/translate
Mozilla Public License 2.0
59 stars 15 forks source link

Add support of Ukrainian models #19

Closed eu9ene closed 2 years ago

abhi-agg commented 2 years ago

@eu9ene Quick question. Have you tested this change?

eu9ene commented 2 years ago

@eu9ene Quick question. Have you tested this change?

I tested locally in Nightly using npm run once. uk-en and other models in English, Spanish and Russian localized Nightly including quality estimation. Should I test in Release too? Is there a difference?

andrenatal commented 2 years ago

Ukrainian is being displayed as an option in the website, probably due the dynamically model registry loading? So, I will merge this with the hope it fixes it, but didn't have time to test.

Screen Shot 2022-06-23 at 3 45 12 PM
eu9ene commented 2 years ago

Yes, as soon as the registry is updated the language is displayed on the website. I tested it locally, it should work.