search

mozilla / translations

The code, training pipeline, and models that power Firefox Translations
https://mozilla.github.io/translations/
Mozilla Public License 2.0
154 stars 33 forks source link

Delete temporary files after successfully generating alignments #755

Closed bhearsum closed 3 months ago

bhearsum commented 3 months ago

I noticed we're uploading these as part of alignments tasks, oops. This patch will remove them only when it completes successfully. If there's no value in keeping them even if something fails, I'll update it to always delete them.

bhearsum commented 3 months ago

My bad. It looks like we actually use these in shortlist? https://github.com/mozilla/firefox-translations-training/blob/1e9799c9bd5d567c3ccdd41114cb0a42388606f6/pipeline/alignments/generate-shortlist.sh#L33

eu9ene commented 3 months ago

My bad. It looks like we actually use these in shortlist?

https://github.com/mozilla/firefox-translations-training/blob/1e9799c9bd5d567c3ccdd41114cb0a42388606f6/pipeline/alignments/generate-shortlist.sh#L33

hm, maybe they shouldn't be in a tmp directory then