search

mozilla / translations

The code, training pipeline, and models that power Firefox Translations
https://mozilla.github.io/translations/
Mozilla Public License 2.0
154 stars 33 forks source link

fix: pass 'permission' to train action #859

Open bhearsum opened 1 month ago

bhearsum commented 1 month ago

This is required for non-generic actions as of 11.0. I mucked this up when I did the upgrade. (See https://taskcluster-taskgraph.readthedocs.io/en/latest/reference/migrations.html.)

bhearsum commented 1 month ago

@ahal - can you advise here? The migration guide says:

If the argument isn’t present, or you are passing generic=False, then add a new argument called permission=, where is the value of whatever you are passing to the cb_name argument.

But we're getting:

[task 2024-09-23T17:54:31.899Z] E           Exception: Unknown callback: train. Known callbacks: rebuild-cached-tasks, retrigger-decision, retrigger-disabled, retrigger, rerun, retrigger-multiple, cancel, cancel-all, add-new-jobs

(Everything seems to work fine without this patch, eg: in https://github.com/mozilla/firefox-translations-training/pull/858 I managed to use the train action.)