mozilla / uniffi-rs

a multi-language bindings generator for rust
https://mozilla.github.io/uniffi-rs/
Mozilla Public License 2.0
2.84k stars 231 forks source link

Make checksums optional #2255

Open alexkirsz opened 1 month ago

alexkirsz commented 1 month ago

We run the uniffi bindgen with Bazel, and our rules ensure there can be no version mismatch between the Rust and foreign language bindings. This makes checksums purely redundant.

We would love to have the option to disable checksums entirely.

mhammond commented 1 month ago

The checksums are to try and ensure the correct library is loaded at runtime, which the build process can't really ensure. #1789 also notes that the checksums aren't particularly adequate for proc-macros anyway, and I don't see an easy fix for that, so this is a reasonable discussion to have.

bendk commented 1 month ago

This seems reasonable to me. I think it could be a top-level field in uniffi.toml.