Closed pdehaan closed 8 years ago
I noticed that we're including all of lodash, as well as dependencies for lodash.debounce and lodash.throttle.
lodash.debounce
lodash.throttle
$ grep -irnl "from 'lodash" . --exclude-dir=node_modules
import debounce from 'lodash.debounce';
import _c from 'lodash/collection'; ... _c.collect(...)
import flatten from 'lodash/array/flatten';
import invoke from 'lodash/collection/invoke';
import throttle from 'lodash.throttle';
I think we can probably remove the lodash dependency switch to the following smaller modules:
lodash
lodash/collection/collect
lodash.map
lodash/array/flatten
lodash.flatten
lodash/collection/invoke
lodash.invoke
PRs welcome. I'd much rather just include all of lodash, because nobody cares about 10 extra KB.
I noticed that we're including all of lodash, as well as dependencies for
lodash.debounce
andlodash.throttle
.import debounce from 'lodash.debounce';
import _c from 'lodash/collection'; ... _c.collect(...)
import flatten from 'lodash/array/flatten';
import invoke from 'lodash/collection/invoke';
import throttle from 'lodash.throttle';
I think we can probably remove the
lodash
dependency switch to the following smaller modules:lodash/collection/collect
tolodash.map
lodash/array/flatten
tolodash.flatten
lodash/collection/invoke
tolodash.invoke