search

mozilla / universal-search

Completed Test Pilot experiment: add-on that inserts server recommendations into the Awesome Bar
https://wiki.mozilla.org/Test_Pilot/Universal_Search
Mozilla Public License 2.0
29 stars 16 forks source link

Universal Search should be marked as multiprocess compatible #291

Closed Standard8 closed 8 years ago

Standard8 commented 8 years ago

Currently Universal Search isn't marked as multiprocess compatible. Although it seems to work, there may still be some incompatibilities that are masked by Firefox's shims.

The shims may also lead to performance issues, although I doubt Universal Search would really be hitting those that hard: https://developer.mozilla.org/Add-ons/SDK/Guides/Multiprocess_Firefox_and_the_SDK#Testing_with_shims_enabled

Setting the flag for Universal Search should be as simple as adding the following to install.rdf:

<em:multiprocessCompatible>true</em:multiprocessCompatible>

Obviously, it should be tested to make sure it does work.

jaredhirsch commented 8 years ago

@Standard8 Thanks for the suggestion! Pull requests welcome :-)

Standard8 commented 8 years ago

@6a68 Although the "patch" is simple, I've found it really helps if someone who is familiar with the code does a short review against https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Limitations_of_chrome_scripts and also exercising the extension with the pref "dom.ipc.shims.enabledWarnings" set to true (and watching the browser console!) before the change.