Key focus broken on Nightly

mozilla / universal-search

Completed Test Pilot experiment: add-on that inserts server recommendations into the Awesome Bar

https://wiki.mozilla.org/Test_Pilot/Universal_Search

Mozilla Public License 2.0

29 stars 16 forks source link

Key focus broken on Nightly #292

Closed jaredhirsch closed 8 years ago

jaredhirsch commented 8 years ago

The latest Nightly changes have broken key focus: if the recommendation is visible, the focus is not released by the existing results when we set selectedIndex = -1.

Need to figure out if it's still possible to steal key focus, and if so, how.

Example:

jaredhirsch commented 8 years ago

Looks like key handling was significantly changed when the one-off buttons were added.

See handleKeyPress in urlbarBindings.xml and handleKeyPress in search.xml.

jaredhirsch commented 8 years ago

This is fixed by disabling the one-off-search-buttons. PR forthcoming.