Closed Hywan closed 7 years ago
This is great. Thanks so much for creating a PR. I left a couple comments in-line.
Also, I noticed you renamed src/localization/fr.l20n
=> src/localization/fr-FR.l20n
, which is fine. To finish this, we'll need to update the localizer's supportedLocales
array too. See https://github.com/mozilla/vaani/blob/d822f46115c7f43b6d142d7b3ad8df6f7e0e0ed3/src/lib/localizer.js#L17
@jedireza Done. Just one question left (hidden by Github): https://github.com/mozilla/vaani/pull/69#discussion_r42976364.
@Hywan my mistake, see reply https://github.com/mozilla/vaani/pull/69#discussion_r43081298
When checking this out I found another bug and created PR #70, so it's good we double checked.
@andrenatal would you like to give this grammar a test drive before we merge?
Also @Hywan let's squash the commits into one. If you need help with squashing commits see:
@jedireza Yes, let me run it with French models and see if compiles well.
@jedireza I know how to squash, thanks! Do you have a specific guide line for the commit message? I wait on @andrenatal's feedback before squashing everything.
Perfect. The first commit message sounds good to me Add French translations.
.
Wow this is getting old. We should try to wrap this up.
@andrenatal What's the latest based on your last message? @Hywan Squashing the commits isn't a bad move, nothing should stop us from merging. Your PR puts French is much better shape than we have now.
Let's :shipit: y'all.
Still relevant?
No. There is no active development on project Vaani and also on FirefoxOS.
Sequel of https://github.com/mozilla/vaani/pull/68#issuecomment-150898640.