mozilla / vinz-clortho

INACTIVE - http://mzl.la/ghe-archive - BrowserID Keymaster for LDAP enabled Identity Providers
16 stars 21 forks source link

Password Manager doesn't prefill with Mozilla IdP #104

Closed ozten closed 10 years ago

ozten commented 11 years ago

Firefox prompts me to remember password, but on the next visit... it doesn't prefill

Steps to reproduce 1) 123done.org with mozilla.com address 2) Remember password 3) Logout 4) https://login.mozilla.org/signout 5) 123done.org log in 6) This is not me 7) enter mozilla.com email 8) Note: no password pre-filled

mostlygeek commented 10 years ago

Maybe because the data is submitted via AJAX and not a regular <form> submit?

shane-tomlinson commented 10 years ago

@mostlygeek - I think you are onto something here, I believe the input elements must be inside a form element that is on the page before DOMContentLoaded.

mostlygeek commented 10 years ago

It could be argued that this is a feature and not a bug. :)

ozten commented 10 years ago

I think your kidding, but to be my usual pedantic self...

It doesn't empower users to chose if they want to use a password manager or not.

mnoorenberghe commented 10 years ago

I fixed this last week in Firefox Nightly. https://bugzilla.mozilla.org/show_bug.cgi?id=583578 It's because the username is readonly and we bailed too easily in that case. Adding readonly/disabled with JS after onload could workaround the issue.

callahad commented 10 years ago

I can confirm that this is fixed in Nightly. Thanks, @mnoorenberghe!

edwindotcom commented 10 years ago

Solution discussed in triage is adding a hidden editable text field to fix for all FF and Chrome password managers.

mnoorenberghe commented 10 years ago

Note that this hidden element should be placed directly before the password field rather than before the input type=text or after the input type=password

ozten commented 10 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=901115

ozten commented 10 years ago

I'm seeing this fixed in Firefox and Safari. It doesn't appear fixed in Chrome, unless I've got my settings wrong or something.

Filed Issue #118 to track Chrome.