search

mozilla / vinz-clortho

INACTIVE - http://mzl.la/ghe-archive - BrowserID Keymaster for LDAP enabled Identity Providers
16 stars 21 forks source link

Changing LDAP password causes third-party cookie warning on first subsequent login. #119

Closed karlht closed 7 years ago

karlht commented 10 years ago

NB: This only seems to show up in production, not on staging.

repro steps are: 1) Log into an RP with a @mozilla.com account, 2) Log out again, 3) Change your LDAP password, wait 5 minutes, and 4) Log in again.

expected: I get re-prompted for the new LDAP password.

actual: I get the 'third-party cookies from login.mozilla.org are disabled' box.

karlht commented 10 years ago

Aha! @edmoz was able to repro this on staging, using beta.123done.org and Safari, by clearing his cookies before logging in. @ozten, I'll look up how to generate HAR files on Safari and see what I can generate for you.

ozten commented 10 years ago

I need some help refining these steps:

Safari Version 6.0.5 (7536.30.1) on Mac 10.7.5 Steps to reproduce 1) https://ldap.mozilla.org/passwordreset/ and wait 5 minutes 2) Safari > Preferences > Privacy > Remove All Website Data 3) beta.123done.org 4) Enter ozten@login.allizom.org

Boom! Except... This didn't repro for me. Anything I'm missing?

karlht commented 10 years ago

4) should be 'Enter ozten@test-moz-idp.com'

karlht commented 10 years ago

Steps to repro on staging /should/ be:

1) Safari > Preferences > Privacy > Remove All Website Data 2) go to beta.123done.org 3) enter ozten@test-moz-idp.com

@edmoz, does this match what you did?

ozten commented 10 years ago

And to double check:

Safari > Preferences > Privacy > Block Cookies set to "Never"

I'm 0 for 5 in trying to reproduce. Must be more to STR... or network latency or .... ?

ozten commented 10 years ago

I'm unable to reproduce.

I'd recommend reverting fd8f2dcf52104 so that we can test and deploy the other fixes in this release.

What is the tag or branch, I'm happy to do the revert.

ozten commented 10 years ago

ping.

karlht commented 10 years ago

The release is rel2013_08_28.15.22.40. Not sure if that identifies a tag or not.

ozten commented 10 years ago

https://github.com/mozilla/vinz-clortho/commits/rel2013_08_28.15.22.40-revert-3rd-p-cookies is a branch that is the same as rel2013_08_28.15.22.40 tag, except fd8f2dcf521046bb4ce6df4e484bf2a7f8d843fb has been reverted.

mostlygeek commented 10 years ago

I created a new release tag: rel2013_09_09.15.45.21 which is based off of ozten's work except it pulls out invalid Changelog data (which is auto-generated) between releases.

FYI: The ghetto release system i built doesn't deal very well w/ this multi-branching release since it is meant to be mostly linear. So something to keep in mind next time we generate a new version.

ozten commented 10 years ago

thanks @mostlygeek !

karlht commented 10 years ago

QA approves rel2013_09_09.15.45.21 for shipping to production. Staging ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=901115 Production ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=915843

Please note that this bug should stay open; the third-party cookies bug is still under investigation.