search

mozilla / vinz-clortho

INACTIVE - http://mzl.la/ghe-archive - BrowserID Keymaster for LDAP enabled Identity Providers
16 stars 21 forks source link

Update server/bin/clortho to be a more modern express app #26

Closed mostlygeek closed 11 years ago

mostlygeek commented 11 years ago

The app.configure("environment", callback) is deprecated. Switch it to a more modern express configuration.

This issue should fix some registration issues too. For example, w/ Express3 apps the error handling middleware should come at the end.

lloyd commented 11 years ago

porting fully to express 3.x would require porting middleware, like the localization stuff. seems like a lot of work for not much payoff. I'm willing to make an incremental improvement?

mostlygeek commented 11 years ago

Good point. Punting this for now.

lloyd commented 11 years ago

FWIW: I actually walked down the path to port to express 3.x - then got scared when I realized I hadda hack i18n-abide :/