Closed SoftVision-CarmenFat closed 5 years ago
@johngruen what should we use here?
should now be resolved
This issue is still reproducible with the pre-release version (v.1.3.5).
Carmen, I could not reproduce this issue using the latest xpi. Please, check the screen cast here: https://www.dropbox.com/s/82spwwbtv6nsoyd/icon-issue.mov?dl=0
After digging more into this issue, I found out that this is reproducible only with Windows and Ubuntu. On macOS, the icon is correctly displayed in the toolbar when Dark theme is enabled.
Hi Carmen, could you please test this again with 1.3.6?
Tested this with Voice Fill v.1.3.6 and I can confirm that the issue is fixed: the icon is now correctly displayed across platforms when Dark theme is enabled.
Indeed, this issue has been fixed but not entirely. It seems that the default buttons color on dark theme is BEBEBE while this fix makes "Voice Fill" button D1D1D2, which is a little bit lighter. Considering this, I'm going to reopen this issue.
@andrenatal can you please take a look at this?
Below is a screenshot with the colors codes for the buttons:
[Affected versions]:
[Affected Platforms]:
[Prerequisites]:
[Steps to reproduce]:
[Expected result]:
[Actual result]:
[Notes]: