search

mozilla / web-ext

A command line tool to help build, run, and test web extensions
Mozilla Public License 2.0
2.71k stars 338 forks source link

ignore-files no longer works with "!(...)" glob pattern #1365

Open Lusito opened 6 years ago

Lusito commented 6 years ago

Is this a feature request or a bug?

bug

What is the current behavior?

web-ext build -i "!(manifest).json" This includes all json files.

What is the expected or desired behavior?

Should ignore all json files except manifest.json. This worked in an older version.. not sure when this changed.

Version information (for bug reports)

Rob--W commented 6 years ago

This behavior changed in #1348 .

Does this address your needs? -i "*.json" -i "!manifest.json"

Lusito commented 6 years ago

Yes, it does, however I think that at least this description has to be updated:

A list of glob patterns to define which files should be ignored. (Example: --ignore-files=path/to/first.js path/to/second.js "*/.log")

Since !(...) is a valid glob pattern and the above statement suggests that it should work.

rpl commented 4 years ago

@Rob--W I'm going to close PR #1874 because I don't think that the change in that PR is really going to be enough to make it clearer why a glob pattern like !(manifest).json doesn't exclude all json files besides manifest.json.

The reason for the change in behavior is that before #1348 !(manifest).json was resolved as /path/to/srcdir/!(manifest).json, after #1348 that pattern is turned into !/path/to/srcdir/(manifest).json).

I'm not sure if the command line options description is a good enough place to explain this properly, it may be more reasonable to try document this option in a bit more detail in the web-ext docs part of https://github.com/mozilla/extension-workshop.