search

mozilla / web-ext

A command line tool to help build, run, and test web extensions
Mozilla Public License 2.0
2.71k stars 338 forks source link

sign command should ignore web-ext-artifacts folder #1640

Open carlin-q-scott opened 5 years ago

carlin-q-scott commented 5 years ago

Is this a feature request or a bug?

Bug

What is the current behavior?

The 'sign' command includes the web-ext-artifacts folder when packaging the extension.

What is the expected or desired behavior?

All web-ext commands should ignore the output folder used by web-ext. The 'build' command already does, which leads to someone testing with a correctly packaged extension and then publishing a bloated extension using the 'sign' command

Version information (for bug reports)

node --version; npm --version; web-ext --version 
v12.3.1
6.9.0
3.1.0

Additional details

It seems the 'sign' command filters out zip and xpi files. So in theory that would exclude whatever is in the artifacts folder. However, I build my extension for Chrome and Opera so there are nex and crx files in the folder, as well as my extension unpacked for testing in Chrome and Opera.

Here's a capture of the output from the sign command: sign.log

Rob--W commented 5 years ago

Could you also show the command that you used to generate the given output?

The observed behavior might be related to #1641

carlin-q-scott commented 5 years ago

Sure, the command I used is: web-ext sign --channel=unlisted --api-key ******* --api-secret *******

Rob--W commented 5 years ago

@carlin-q-scott Does this still happen with the latest version (3.1.1) ? That version contains a fix to #1641.

carlin-q-scott commented 5 years ago

Yes, this issue is still present in v3.1.1