search

mozilla / web-ext

A command line tool to help build, run, and test web extensions
Mozilla Public License 2.0
2.68k stars 338 forks source link

fix: Cannot find Firefox package on device with work profile (#2857) #3146

Closed willdurand closed 4 months ago

willdurand commented 4 months ago

Backport to v7, see https://github.com/mozilla/web-ext/issues/3116#issuecomment-2133844621

willdurand commented 4 months ago

There is a failure caused by npm audit which is not unknown: https://github.com/mozilla/web-ext/issues/2678 err, that's a new one. I am going to ignore it.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (minor-releases-7.x.x@ffcf07d). Learn more about missing BASE report.

:exclamation: Current head 79f3fff differs from pull request most recent head 241acd8

Please upload reports for the commit 241acd8 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## minor-releases-7.x.x #3146 +/- ## ======================================================= Coverage ? 99.52% ======================================================= Files ? 32 Lines ? 1686 Branches ? 0 ======================================================= Hits ? 1678 Misses ? 8 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

willdurand commented 4 months ago

The PR also includes an advisory ignore. Was that intentional? Would you consider moving the ignore to a separate pr+commit to untangle it from this unrelated PR?

Sure, done.