search

mozilla / web-ext

A command line tool to help build, run, and test web extensions
Mozilla Public License 2.0
2.71k stars 339 forks source link

v8 deprecation warnings #3150

Open wagnerand opened 5 months ago

wagnerand commented 5 months ago 
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@2.4.5: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@6.0.4: Glob versions prior to v9 are no longer supported

Some of these would need to be resolved in addons-linter (see below), but for web-ext, we should probably replace bunyan by something that is still maintained.

inflight

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ └─┬ eslint@8.57.0
  │   └─┬ file-entry-cache@6.0.1
  │     └─┬ flat-cache@3.2.0
  │       └─┬ rimraf@3.0.2
  │         └─┬ glob@7.2.3
  │           └── **inflight@1.0.6 deduped**
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └─┬ rimraf@2.4.5
        └─┬ glob@6.0.4
          └── **inflight@1.0.6**

rimraf

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ └─┬ eslint@8.57.0
  │   └─┬ file-entry-cache@6.0.1
  │     └─┬ flat-cache@3.2.0
  │       └── **rimraf@3.0.2**
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └── **rimraf@2.4.5**

glob

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ ├─┬ eslint@8.57.0
  │ │ └─┬ file-entry-cache@6.0.1
  │ │   └─┬ flat-cache@3.2.0
  │ │     └─┬ rimraf@3.0.2
  │ │       └── **glob@7.2.3**
  │ └── glob@10.4.1
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └─┬ rimraf@2.4.5
        └── **glob@6.0.4**
Rob--W commented 5 months ago

addons-linter dependency issues is tracked at https://github.com/mozilla/addons-linter/issues/5311

Rob--W commented 5 months ago

bunyan's mv dependency issue was reported before at https://github.com/trentm/node-bunyan/issues/719

wagnerand commented 5 months ago

bunyan's mv dependency issue was reported before at trentm/node-bunyan#719

bunyan hasn't seen a release in 3 years and a commit in 2 years. It's probably better to replace it with another logger, than waiting for an update.

Rob--W commented 5 months ago

bunyan's mv dependency issue was reported before at trentm/node-bunyan#719

bunyan hasn't seen a release in 3 years and a commit in 2 years. It's probably better to replace it with another logger, than waiting for an update.

In that linked issue, the purpose of mv was mentioned. If the feature is not needed by addons-linter, a simpler fix could be to add overrides to our package.json to swap out the mv dependency: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

fregante commented 4 months ago

These two will fix all the issues mentioned here.

willdurand commented 4 months ago

Yeah. So for eslint v9, most plugins must be compatible and that wasn't the case last time I checked.

l10nelw commented 2 days ago

Unable to install web-ext because of these errors.

(WSL, Windows 10)

l10nelw commented 1 day ago

Apologies, found the issue, NodeJS was installed on Windows itself not on WSL. Very embarrassing