search

mozilla / web-ext

A command line tool to help build, run, and test web extensions
Mozilla Public License 2.0
2.72k stars 341 forks source link

feat: remove --disable-component-update from default args #3298

Closed andrea11 closed 1 week ago

andrea11 commented 2 weeks ago

Similarly to puppeteer/puppeteer#13010, Quoting @mathiasbynens:

Summarizing the “why” here:
The --disable-component-update command-line flag does two things: it disables component updates (desired) but it also prevents any bundled components from being initialised (undesired).

Disable this flag grant more flexibility, and it can always be disabled via the web-ext run --arg option

andrea11 commented 2 weeks ago

Can someone review this PR? (@willdurand maybe?)

willdurand commented 1 week ago

I'd prefer to not auto-download a bunch of extra stuff, but since it is currently possible to add it again, but not to opt out, I reluctantly approve this change.

I am not clear on what that means, @Rob--W.

Rob--W commented 1 week ago

I'd prefer to not auto-download a bunch of extra stuff, but since it is currently possible to add it again, but not to opt out, I reluctantly approve this change.

I am not clear on what that means, @Rob--W.

I am approving this change, even if it means that Chrome will auto-download some additional components after startup. This will utilize extra bandwidth and CPU when launching (new) browser profiles instances. In exchange for that downside, the upside is that the launched Chrome browser will more closely match production. One example of that is that websites requiring DRM will work.

If devs want to revert to the behavior from before, they can manually add the command line flag to web-ext run.

TL;DR: LGTM, let's merge.