search

mozilla / webextension-polyfill

A lightweight polyfill library for Promise-based WebExtension APIs in Chrome
Mozilla Public License 2.0
2.69k stars 215 forks source link

Avoiding listing WebPack as a production dependency #604

Closed fabiospampinato closed 4 months ago

fabiospampinato commented 5 months ago

I'm not sure how it happened exactly, but this module seems to depend on webpack and webpack-cli, which are listed as production dependencies in the package release to NPM, even though the package.json in the repo doesn't list any production dependencies, and depending on webpack and webpack-cli in production doesn't really make sense for almost any package.

Can this be fixed?

Gudahtt commented 4 months ago

Presumably it was an unintended consequence of this change: https://github.com/mozilla/webextension-polyfill/pull/597

cc @Rob--W @rpl

The resulting manifest in v0.11.0 can be seen here: https://npmfs.com/package/webextension-polyfill/0.11.0/package.json

Rob--W commented 4 months ago

We should add --no-save to the npm install command. Otherwise npm will add it to package.json