Closed Gudahtt closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.71%. Comparing base (
89a7281
) to head (789c249
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the analysis and fix. Although --no-save
could have fixed the issue, adding it to devDependencies signals more clearly that it is a potential dependency in any test. It would also make it easier to identify external regressions in the smoke tests, hence I merged this PR instead of adding a --no-save
fix.
Thanks! Good point that --no-save
would have been simpler, I forgot that flag existed. I prefer this fix for the same reasons you mentioned though.
Changes made in #597 accidentally resulted in
webpack
andwebpack-cli
being added as dependencies in the manifest of the published package. This problem can be seen in v0.11.0. For more information, see #604.webpack
andwebpack-cli
are used for bundler smoke tests that are run in CI. Rather than being installed during CI, these dependencies are now included indevDependencies
. A new npm script has been added for running this script as well, to ensure that these dependencies are on the PATH when this script is run.The CircleCI config and the contributor docs have been updated to use the new npm script. You can test it by running
npm run test-module-bundlers-smoketest
.Fixes #604