search

mozilla / webmaker-addons

Prototypes for add-ons. Gateways from browser to Webmaker.
http://mozilla.github.io/webmaker-addons/
4 stars 2 forks source link

Revamp sharing modal #40

Closed toolness closed 9 years ago

toolness commented 9 years ago

This is what it looks like in reference.html:

screen shot 2015-02-12 at 1 31 37 pm

I guess doing a lot of the social network options will mean hosting the image somewhere first.

davidascher commented 9 years ago

For the purpose of demo, we can just make an unauthed POST-to-s3 endpoint.

On Thu, Feb 12, 2015 at 10:34 AM, Atul Varma notifications@github.com wrote:

This is what it looks like in reference.html http://xmatthewx.github.io/webmaker-addons/reference.html:

[image: screen shot 2015-02-12 at 1 31 37 pm] https://cloud.githubusercontent.com/assets/124687/6174271/a9607b8a-b2bb-11e4-8c0c-70d921548149.png

I guess doing a lot of the social network options will mean hosting the image somewhere first.

— Reply to this email directly or view it on GitHub https://github.com/xmatthewx/webmaker-addons/issues/40.

xmatthewx commented 9 years ago

Would be nice to auto copy url to clipboard and notify user.

xmatthewx commented 9 years ago

The webmaker icon could pop open your modal with him.

xmatthewx commented 9 years ago

Ha. Auto correct. Html, not him.

xmatthewx commented 9 years ago

For demo, share could include 3 buttons. Text labels are fine. View Image, Copy Link, Share as a Page.

toolness commented 9 years ago

Ok, I've got this done for the demo... don't have it uploading to S3 or anything but can add that later, which I filed #43 for.