Closed xmatthewx closed 9 years ago
If this weren't just a proof of concept, I'd argue that we need to think pretty deeply about the sidebar -- how to introduce the feature, how to have the slurping of an image when sidebar is closed hint that the sidebar is there, etc. But given that it's just a proof of concept, I don't think it's worth spending a lot of time on this.
On Mon, Feb 16, 2015 at 12:29 PM, matthew w notifications@github.com wrote:
I like the animate in #10 https://github.com/xmatthewx/webmaker-addons/issues/10. It's fun and helps explain this unfamiliar experience. When the sidebar is already open, it works smoothly.
Adding the first image, however, there's a big lag between step 2 and 3.
- animate image on page
- open sidebar
- animate image in sidebar
The sidebar background colors aren't there initially. If the image lag is unavoidable, adding the colors and a spinner will help.
— Reply to this email directly or view it on GitHub https://github.com/xmatthewx/webmaker-addons/issues/45.
Fair enough. Keeping open in case there's a quick fix. Otherwise, @toolness feel free to close.
To make a good first impression, but keep things simple:
By "adjust order of operations" I assume you mean the thing about parallelizing the firebase sync with the loading of UI code, rather than doing one after the other?
Hmm, so upon further reflection it seems the order of operations thing will actually take a lot longer to implement than I anticipated, and it might not even be particularly useful, so I'm going to bail on it. (More useful would probably be to optimize the requirejs bundle so that the page loads faster, but that's a bit of a hassle too... still, if the page load time is a significant concern, we can do it.)
I like the animation in #10. It's fun and helps explain this unfamiliar experience. When the sidebar is already open, it works smoothly.
Adding the first image, however, there's a big lag between step 2 and 3.
The sidebar background colors aren't there initially. If the image lag is unavoidable, adding the colors and a spinner will help.