search

mozilla / webmaker-addons

Prototypes for add-ons. Gateways from browser to Webmaker.
http://mozilla.github.io/webmaker-addons/
4 stars 2 forks source link

Some "+" icons are unreachable #61

Open toolness opened 9 years ago

toolness commented 9 years ago

Sometimes the "+" icons aren't appearing in areas that seem to be at the top-right of an image. While this is unfortunate from a purely aesthetic standpoint, it makes the image un-importable when the icon is outside of the "hoverable" area of the element it's on. An example is the carousel area of Yahoo's front page:

2015-02-20_12-08-38

It's impossible to click on the "+" icon in the image above, because as soon as one moves their mouse outside of the carousel, the "+" disappears.

toolness commented 9 years ago

Weird--in the Yahoo example, it seems this is happening because the image is relatively positioned within its parent container; it's actually bigger than its parent container, and is being clipped by it. getBoundingClientRect(), which is used by the content script code, is returning the size of the actual image, rather than its clipped size.

toolness commented 9 years ago

With #51 fixed and the user able to drag images (even hyperlinked ones) into the sidebar, at least there's a workaround for this issue now, even if it's not a particularly obvious one.