search

mozilla / webmaker-android

Webmaker for Android
https://play.google.com/store/apps/details?id=org.mozilla.webmaker
Mozilla Public License 2.0
167 stars 113 forks source link

adding Web Link view #2449

Closed gvn closed 8 years ago

gvn commented 8 years ago

Enables https://github.com/mozilla/webmaker-core/pull/802

alanmoo commented 8 years ago

These could apply to https://github.com/mozilla/webmaker-core/pull/802 as well

There's a bug that I'm having trouble replicating in which the first page no longer becomes tappable in the project overview. It seems to get triggered with some combination of creating a link, tapping the initial "set destination" and then backing out if it, but I can't pinpoint it. The page becomes greyed out in the "set destination view" and remains like that even in the "add page" view, like the rest of the "add page" placeholders around it. It stays this way even after adding more pages, and the only way to change it is to delete all other pages and then you can go in to edit mode, which defaults to that page.

gvn commented 8 years ago

When in the view to add a link to web, I can't back out of it unless I have content

Fixed.

Should the validation message update as the user types?

Yep, fixed.

I'm assuming it's by design that the initial "Set Destination" action on buttons is only for within the project? Seemed a little odd at first but I understand why we might do that- web links are an advanced feature, right?

Yeah, I think we settled on leaving that as-is for this round of implementation and seeing how it feels.

gvn commented 8 years ago

Fixups are in: https://github.com/mozilla/webmaker-core/pull/802

gvn commented 8 years ago

As to that last bug...let me know if you get solid repro steps. Maybe file a follow-up if not...

alanmoo commented 8 years ago

Sounds good. Figured the greying of the page might ring a bell, but I'll play around with it some more when I review this.

alanmoo commented 8 years ago

After setting a link to an external URL, the button still has the "Set Destination" button below it in the edit page view. Not sure if this is desired or not.

After following a button to an external URL from the first page of a project, returning to Webmaker results in an inability to use the arrow button to change pages within the project unless you zoom out and in again.

After following a button to an external URL from another page in the project, switching back to Webmaker and results in the project returning to its first page.

xmatthewx commented 8 years ago

switching back to Webmaker and results in the project returning to its first page.

This refresh happens other times you leave the app. Always a little annoying, worse in this scenario. @gvn should we file this a separate issue?

the button still has the "Set Destination" button below it

We might want to remove the "set destination" helper button. Since "set destination" helper doesn't offer URL as an option, it risks more harm than good. "Follow link" helper should remain. What do you think?

gvn commented 8 years ago

switching back to Webmaker and results in the project returning to its first page.

This refresh happens other times you leave the app. Always a little annoying, worse in this scenario. @gvn should we file this a separate issue?

Yeah, if we could do that separately it would help move things forward.

the button still has the "Set Destination" button below it

We might want to remove the "set destination" helper button. Since "set destination" helper doesn't offer URL as an option, it risks more harm than good. "Follow link" helper should remain. What do you think?

Sounds good to me. I'll make that change...

xmatthewx commented 8 years ago

filed https://github.com/mozilla/webmaker-core/issues/840 on auto-refresh of projects

alanmoo commented 8 years ago

After following a button to an external URL from the first page of a project, returning to Webmaker results in an inability to use the arrow button to change pages within the project unless you zoom out and in again.

I'm still getting this @gvn. Is this part of https://github.com/mozilla/webmaker-core/issues/840 as well?

xmatthewx commented 8 years ago

Unrelated to @alanmoo's question ... but in case you didn't notice, we'd like to add an icon to links that go to URLs, so people viewing a project can distinguish. https://github.com/mozilla/webmaker-core/issues/797