Closed gvn closed 9 years ago
Note: On that sample project you'll get a warning "Warning: Failed propType: Invalid prop targetProjectId
of type number
supplied to Link
, expected string
. Check the render method of BasicElement
."
This is due to legacy data in the db...
@gvn Does a db migration have to happen to prevent that or is it only something that will happen in staging?
Also on http://localhost:8000/#/thumbnail?user=1&project=1&page=1 I'm getting a 404 in the console as it looks for flag.svg. I'm guessing that's also just a project data issue?
The warning should only show up for really old projects. DB migration isn't really worth it since it doesn't cause any functional issues.
The flag.svg has been missing for a while...it's not actually used in desktop (it's for setting link destination). We should probably fix this, but in another issue.
Good call on https...I'll tweak that.
victory :v: :boom:
Note: I unbundled React and React DOM because they were getting packaged twice by webpack.
Follow on ticket: https://github.com/mozilla/webmaker-core/issues/748