search

mozilla / webmaker-browser

Webmaker for Browsers
https://webmaker.org
Mozilla Public License 2.0
46 stars 35 forks source link

Adding Thimble Promo #291

Closed vazquez closed 8 years ago

vazquez commented 8 years ago

@mmmavis Can I get a PR review on this please? 😄

xmatthewx commented 8 years ago

yay!

mmmavis commented 8 years ago

Looks great! R+ :tada:

Wondering if we should remove Maker Party related strings from en-US.yaml and #mp-promo CSS code? Feel like it's unlikely that we will reuse them again... but I might be wrong :wink:

vazquez commented 8 years ago

I think we might use them again based on our convo with Erika today. I'll reach out to Paul before removing that code!

mmmavis commented 8 years ago

sounds good! thanks @vazquez :dancer: