search

mozilla / webmaker.org

deprecated - https://blog.webmaker.org/whats-next-for-webmaker-tools
https://webmaker.org
Mozilla Public License 2.0
71 stars 99 forks source link

Nav broken on Explore with small screens #1176

Open xmatthewx opened 9 years ago

xmatthewx commented 9 years ago

While viewing /explore on small screens, the hamburger nav is missing bacon, lettuce, and tomato. Tap the box... nothing happens.

Logged-in users are now sent to Explore and get rather stuck. Problem appears on desktop and mobile, chrome and firefox.

screenshot 2015-01-22 18 44 50

Also, the CTA that appears after a delay is not responsive.

xmatthewx commented 9 years ago

On full width browser, nav items fall to the left instead of centering as on other pages.

gesa commented 9 years ago

I think I've chased this down to this commit: https://github.com/mozilla/webmaker.org/commit/1b38624340145d12c8b0861265c8ca9385333dd3 but I'm not entirely certain how to fix it. The problem appears, to me, to be that the markup for the menu on /explore is basically copied from the angular pages. The problem is that https://github.com/mozilla/webmaker.org/blob/master/public/js/base/navigation.js hasn't been updated since February of last year, so the classes and structure don't mesh. This has a lot to do with Login, so I just wanted to ping @jbuck to see if there's a clear-cut, straightforward solution to this that I might be missing.

ScottDowne commented 9 years ago

I've been looking into this too.

Going to re pring @jbuck

He likely didn't see the ping.

ScottDowne commented 9 years ago

From what I can tell a click event was never created for this to be used the non angular way.

Need something to connect ng-click attribute to the controllers.js $scope events? Dunno.

ScottDowne commented 9 years ago

Fixed here: https://github.com/mozilla/webmaker.org/pull/1380

After running around angular for a bit, I figured out the not terrible fix.