search

mozilla / webmaker.org

deprecated - https://blog.webmaker.org/whats-next-for-webmaker-tools
https://webmaker.org
Mozilla Public License 2.0
71 stars 99 forks source link

Tweaks - disabled India Report link, replaced video with the real one #1356

Closed mmmavis closed 9 years ago

edrushka commented 9 years ago

@simonwex pinging so this doesn't fall through the cracks. I know there's a ton happening today. Thanks.

mmmavis commented 9 years ago

:exclamation: UPDATES we are having problem with video link, will replace it with a new one soon. do NOT merge this PR yet

simonwex commented 9 years ago

@mmmavis let me know when you want a review, it looks good once linting passes.

mmmavis commented 9 years ago

@simonwex Video link has been updated again! Review :+1: ?

thisandagain commented 9 years ago

Thanks for getting the india link updated @mmmavis !

simonwex commented 9 years ago

R+ :+1:

edrushka commented 9 years ago

I can't see these changes live, even with command-R. When will they be visible? @simonwex

HPaulJohnson commented 9 years ago

Blog post and press event tomorrow (3/1) afternoon (Barcelona time) so let's make sure all changes go live today. Thx!

mmmavis commented 9 years ago

@simonwex I can help with deploying but I'm not sure if the master branch contains anything that shouldn't be pushed to prod :open_mouth:

cc @secretrobotron @jbuck

jdotpz commented 9 years ago

We're doing press on it for a Sunday, and this is the first we're hearing about going live over the weekend in DevOps ? For shame! :) If you have something that is going live on a weekend and JP/DevOps doesn't know about it before Friday at 9pm, we're doing it wrong. I'll look at the branch Mavis

jdotpz commented 9 years ago

https://github.com/mozilla/webmaker.org/compare/5ce88bf...abd738b is the compare between the last tag that went to prod (v1.1.139) and the newer branch. @k88hudson and @secretrobotron have some lint / styling updates that didn't go with any tag yet, but that shouldn't block us to push this to staging mavis. Go ahead and do the tagging process we worked on.

git checkout master git pull npm version patch git push mozilla master --tags (I think this is right, you can verify in your history mavis)

That will auto build and push to staging. Verify your changes there, and then you can use Jenkins to go to prod!

k88hudson commented 9 years ago

@mmmavis go for it, everything is good to push

k88hudson commented 9 years ago

also, that's correct @jdotpz

edrushka commented 9 years ago

Update: @mmmavis will do this around 11pm Pacific tonight (Saturday Feb 28).

mmmavis commented 9 years ago

v1.1.140 on staging Everything looks fine. I'm gonna push it to prod now.

mmmavis commented 9 years ago

v1.1.140 on prod now.