search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

Fix parsing of unknown extensions in candidate attribute #103

Closed Johni0702 closed 5 years ago

Johni0702 commented 5 years ago

With regards to the candidate attribute, RFC5245 (as well as it's potential successor) states that:

An implementation MUST ignore any name/value pairs it doesn't understand.

However, currently an error is returned.

Side-note: This PR does not concern itself with the FIXME in its diff because, as I understand it, it's unrelated to unknown name/value pairs (the reason that test was failing till now). To make that clear, the PR even adds another test case.

codecov-io commented 5 years ago

Codecov Report

Merging #103 into master will decrease coverage by 1.51%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   86.72%   85.21%   -1.52%     
==========================================
  Files           7        7              
  Lines        4293     4564     +271     
==========================================
+ Hits         3723     3889     +166     
- Misses        570      675     +105
Impacted Files Coverage Δ
src/attribute_type.rs 82.44% <87.5%> (-2.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ff7237...0ecec6c. Read the comment docs.