search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

Incorporate review feedback for anonymization work #124

Closed na-g closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #124 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files           7        7              
  Lines        3443     3441       -2     
==========================================
- Hits         3103     3101       -2     
  Misses        340      340
Impacted Files Coverage Δ
src/attribute_type.rs 89.13% <100%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63d6ef8...e8e4fcf. Read the comment docs.

na-g commented 5 years ago

Ah, reducing coverage by reducing the total lines in the codebase. That is one type of reduced coverage I can live with.