search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

fixed memory leak when parsing image_attr #151

Closed nils-ohlmeier closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #151 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage    90.5%   90.69%   +0.18%     
==========================================
  Files           7        7              
  Lines        3551     3557       +6     
==========================================
+ Hits         3214     3226      +12     
+ Misses        337      331       -6
Impacted Files Coverage Δ
src/attribute_type.rs 88.74% <100%> (+0.32%) :arrow_up:
src/media_type.rs 92.92% <0%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac5024c...88402e2. Read the comment docs.

nils-ohlmeier commented 5 years ago

There is now a rust-lang issue for why we have to do this https://github.com/rust-lang/rust/issues/62289 It might makes sense to wait and see what people are saying on that issue.

nils-ohlmeier commented 5 years ago

So rust-lang/rust#62289 has been fixed upstream and I just confirmed that with the latest rust nightly and the test case from fuzzing the code is no longer leaking. So we close this and not merge, as it is actually not a bug in our code.