search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

FQDN Work #160

Closed na-g closed 5 years ago

na-g commented 5 years ago

This is ready for review. I expect CCOV to find test holes, and that I will have to plug them before merging.

codecov-io commented 5 years ago

Codecov Report

Merging #160 into master will decrease coverage by 1.27%. The diff coverage is 73.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   90.69%   89.41%   -1.28%     
==========================================
  Files           7        8       +1     
  Lines        3557     3647      +90     
==========================================
+ Hits         3226     3261      +35     
- Misses        331      386      +55
Impacted Files Coverage Δ
src/media_type.rs 92.9% <100%> (-0.02%) :arrow_down:
src/anonymizer.rs 92.08% <46.66%> (-5.5%) :arrow_down:
src/address.rs 67.34% <67.34%> (ø)
src/error.rs 69.67% <76.31%> (-2.65%) :arrow_down:
src/network.rs 87.09% <88.88%> (-10.21%) :arrow_down:
src/attribute_type.rs 88.55% <88.88%> (-0.2%) :arrow_down:
src/lib.rs 92.16% <90%> (-0.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a46c37...0bdb045. Read the comment docs.