search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

Remove v rtpmap param check #196

Closed na-g closed 4 years ago

na-g commented 4 years ago

The backs out the parameter check here, as it was probably too strict.

nils-ohlmeier commented 4 years ago

@na-g do you think enconding parameters are in general allowed in video rtpmap's by the spec?

I guess I would prefer to leave this in as a warning if possible (instead of removing the check all together), but I don't know if that is going to cause more problems.

na-g commented 4 years ago

@na-g do you think enconding parameters are in general allowed in video rtpmap's by the spec?

I guess I would prefer to leave this in as a warning if possible (instead of removing the check all together), but I don't know if that is going to cause more problems.

I agree that this this should at least be a warning. I will open a new issue with a new PR for this. This is the type of thing that if allowed by the spec, or even by a reasonably relaxed parser would be a good thing for a linter to catch.