Unknown rtcpfb feedback type: "rrtr“ ?

yuebinyun commented 3 years ago

Some(x) => match *x {
    "ack" => SdpAttributeRtcpFbType::Ack,
    "ccm" => SdpAttributeRtcpFbType::Ccm,
    "nack" => SdpAttributeRtcpFbType::Nack,
    "trr-int" => SdpAttributeRtcpFbType::TrrInt,
    "goog-remb" => SdpAttributeRtcpFbType::Remb,
    "transport-cc" => SdpAttributeRtcpFbType::TransCc,
    _ => {
        return Err(SdpParserInternalError::Unsupported(format!(
            "Unknown rtcpfb feedback type: {:?}",
            x
        )));
    }
},

Unsupported { error: Unsupported("Unknown rtcpfb feedback type: \"rrtr\""), line: "a=rtcp-fb:111 rrtr", line_number: 26 }

fuzzy-coats commented 3 years ago

@yuebinyun I am not familiar with the rrtr feedback type. Is there an RFC you could point me to?

mstyura commented 3 years ago

I've noticed that rrtr feedback type is used in Google Meet. Found definition of rrtr in Chromium source.

na-g commented 3 years ago

Firefox issue filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1729757

mozilla / webrtc-sdp

Unknown rtcpfb feedback type: "rrtr“ ? #253