mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

Inappropriate validation of direction consistency between simulcast attr and direction attr #267

Closed docfaraday closed 1 year ago

docfaraday commented 1 year ago

This code needs to be removed:

https://github.com/mozilla/webrtc-sdp/blob/master/src/lib.rs#L701-L721

While it may seem silly to put a send simulcast attr in a recvonly or inactive m-section (or recv in a sendonly/inactive), it is not invalid, and webrtc-pc is written such that removing the simulcast attr will result in permanently disabling simulcast, which is not what we want.

Here's the bug on the Firefox side: https://bugzilla.mozilla.org/show_bug.cgi?id=1807193