search

mozilla / webrtc-sdp

Rust SDP parser for WebRTC
Mozilla Public License 2.0
155 stars 30 forks source link

Consolidate direction attribute #76

Closed Paul-E closed 7 years ago

Paul-E commented 7 years ago

We have SdpAttributeDirection with Recvonly, Sendonly, and Sendrecv. We also have SdpAttribute whicih has Recvonly, Sendonly, and Sendrecv. If these are the same, we should consolidate them.

nils-ohlmeier commented 7 years ago

The SdpAttributeDirection is only used for 'extmap' which explicitly does not support the 'Inactive' value (because it makes no sense). But the SdpAttribute actually contains 'Inactive', 'Recvonly', 'Sendonly' and 'Sendrecv'. So no they are not the same. And I don't see an easy way to define one as the super set of another. So I suggest don't try to consolidate these.