search

mozilla / wg-decisions

A place for Gecko developers to track CSSWG decisions
9 stars 2 forks source link

[cssom-view] Remove `caret range` concept from `CaretPosition` interface #1474

Open mozilla-apprentice opened 4 months ago

mozilla-apprentice commented 4 months ago

A resolution was made for csswg-drafts/#10230.

[cssom-view] Remove `caret range` concept from `CaretPosition` interface

Discussion.

To file a bug automatically for these resolutions, add the bug label to the issue.

If no bug is needed, the issue can be closed.

aethanyc commented 4 months ago

@smaug---- Do we have to change gecko implementation for this spec change?

smaug---- commented 4 months ago

https://searchfox.org/mozilla-central/rev/010ccb86d48fa23b2874d1a7cbe6957ec78538c3/dom/base/nsDOMCaretPosition.cpp#32,36,40 seems to map to the new spec text https://drafts.csswg.org/cssom-view/#dom-caretposition-getclientrect step 2.

But, I'm not sure about https://searchfox.org/mozilla-central/rev/010ccb86d48fa23b2874d1a7cbe6957ec78538c3/dom/base/nsRange.h#260 Should https://searchfox.org/mozilla-central/rev/010ccb86d48fa23b2874d1a7cbe6957ec78538c3/dom/base/nsDOMCaretPosition.cpp#40 pass true not false? I don't know what aClampToEdge means.