search

mozilla / wg-tracker

A tool to help Gecko developers keep track of CSSWG decisions
4 stars 0 forks source link

tracker should ignore resolutions in quoted text #3

Open heycam opened 3 years ago

heycam commented 3 years ago

https://github.com/mozilla/wg-decisions/issues/443 is an issue that was automatically filed by @mozilla-apprentice after noticing a "RESOLVED:" within some quoted text. It should probably ignore quoted text (and perhaps any instance of "RESOLVED:" not at the start of a line).

heycam commented 3 years ago

And I guess this is because it's looking at the issue comment as plain text rather than Markdown or HTML, and in plain text the quote marker doesn't get converted into a > or anything.

https://github.com/heycam/wg-tracker/blob/5ddf4f77a276f7cc41a3c4412c8ff56a06db9f59/src/query/issue_comments.graphql#L1-L18

https://github.com/heycam/wg-tracker/blob/5ddf4f77a276f7cc41a3c4412c8ff56a06db9f59/src/github_schema.graphql#L1404-L1407

heycam commented 3 years ago

Parsing Markdown / HTML doesn't sound fun here. Maybe we can remember resolution text that we've already handled on a given issue, and avoid filing a new issue if we've already seen the resolution before.