search

mozilla / womenandweb

INACTIVE - http://mzl.la/ghe-archive - This repository hosts the code used to power the Women and Web Literacy hub's website
https://mozilla.github.io/womenandweb
Mozilla Public License 2.0
8 stars 9 forks source link

Content and styling updates #27

Closed flukeout closed 8 years ago

flukeout commented 8 years ago

Styled the page to match the designs in the redpen and added in the missing content.

In addition to a code review, can we move this into some kind of staging environment so that we can start a QA process for content and design.

cc @gideonthomas

gideonthomas commented 8 years ago

I'll create a temporary heroku app for this.

flukeout commented 8 years ago

Thank you!

gvn commented 8 years ago

The logos look kinda funky for mobile:

screen shot 2016-08-29 at 10 50 06 am
gvn commented 8 years ago

We should use px as little as possible for responsive layouts. rem is what should be used instead.

em is ok if you truly want something expressed based relative to a font size (eg: typography).

gvn commented 8 years ago

classroom-bg.png and header-bg.png should be JPEGs. Can you add opacity via CSS?

gvn commented 8 years ago

All partner logos should be SVG or PNG.

gvn commented 8 years ago

@flukeout This is looking great. Just some various fixes & tweaks! 👍

flukeout commented 8 years ago

@gvn curious about rationale for...

Otherwise, all linting is complete! Thanks for the thorough review.

flukeout commented 8 years ago

@gideonthomas removed procfile

gideonthomas commented 8 years ago

@flukeout ok I'll merge it in. Thank you!

flukeout commented 8 years ago

Cool thanks!

gvn commented 8 years ago

All partner logos should be SVG or PNG.

Any low-color image should be SVG or PNG because JPEG is for photos. SVG and PNG compress low color imagery way better, so file size & quality are the reasons.

classroom-bg.png and header-bg.png should be JPEGs

They are very large as PNGs (over 200k each). As JPEGs they can be a fraction of that size.